Skip to content

minor: add Any to QueryPlanner trait#22241

Open
milenkovicm wants to merge 3 commits into
apache:mainfrom
milenkovicm:minor_query_planner_any
Open

minor: add Any to QueryPlanner trait#22241
milenkovicm wants to merge 3 commits into
apache:mainfrom
milenkovicm:minor_query_planner_any

Conversation

@milenkovicm
Copy link
Copy Markdown
Contributor

@milenkovicm milenkovicm commented May 16, 2026

Which issue does this PR close?

  • does not close the issue.

Rationale for this change

Working on #22151 it seams that QueryPlanner should extend Any in order to be downcastad to actual implementation. The main reason behind cast is to support runtime change of inner query planner.

What changes are included in this PR?

  • trait QueryPlanner extends Any

Are these changes tested?

Using existing tests

Are there any user-facing changes?

this would be backward incompatible change

@github-actions github-actions Bot added the core Core DataFusion crate label May 16, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 16, 2026 •
edited
Loading

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details 
     Cloning apache/main
    Building datafusion v53.1.0 (current)
       Built [  93.022s] (current)
     Parsing datafusion v53.1.0 (current)
      Parsed [   0.034s] (current)
    Building datafusion v53.1.0 (baseline)
       Built [  93.688s] (baseline)
     Parsing datafusion v53.1.0 (baseline)
      Parsed [   0.035s] (baseline)
    Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch)
     Checked [   0.604s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip

--- failure trait_added_supertrait: non-sealed trait added new supertraits ---

Description:
A non-sealed trait added one or more supertraits, which breaks downstream implementations of the trait
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#generic-bounds-tighten
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/trait_added_supertrait.ron

Failed in:
  trait datafusion::execution::context::QueryPlanner gained Any in file /home/runner/work/datafusion/datafusion/datafusion/core/src/execution/context/mod.rs:2077

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [ 189.556s] datafusion

@github-actions github-actions Bot added the auto detected api change Auto detected API change label May 16, 2026
xudong963
xudong963 reviewed May 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about mentioning the change in upgrade doc

@milenkovicm milenkovicm force-pushed the minor_query_planner_any branch from 93015be to a90e1bf Compare May 17, 2026 07:18
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 17, 2026
@milenkovicm
Copy link
Copy Markdown
Contributor Author

milenkovicm commented May 17, 2026

thanks @xudong963 good catch, should be updated now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xudong963 xudong963 xudong963 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

auto detected api change Auto detected API change core Core DataFusion crate documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@milenkovicm @xudong963